Minor modifications in provisioning #3919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sweetymhaiske
force-pushed
the
provision-fixes
branch
3 times, most recently
from
48ce1f7 to
ebd5735
Compare
dhrishi
reviewed
Apr 21, 2020
dhrishi
reviewed
Apr 21, 2020
sweetymhaiske
force-pushed
the
provision-fixes
branch
2 times, most recently
from
ac31df6 to
f0f0ff3
Compare
me-no-dev
reviewed
Apr 21, 2020
| @@ -151,7 +151,9 @@ void WiFiProvClass :: beginProvision(scheme prov_scheme, wifi_prov_event_handler | |||
| WiFi.mode(WIFI_MODE_STA); | |||
| log_i("Aleardy Provisioned, starting Wi-Fi STA"); | |||
| log_i("CONNECTING ACCESS POINT CREDENTIALS : "); | |||
| log_i("SSID : %s\n",WiFi.SSID().c_str()); | |||
| wifi_config_t conf; | |||
There was a problem hiding this comment.
you should check if the log level is info or higher, else this will cause unused variable and is unnecessary in reality.
sweetymhaiske
force-pushed
the
provision-fixes
branch
from
f0f0ff3 to
20d5550
Compare
vvhh2002
pushed a commit
to vvhh2002/arduino-esp32
that referenced
this pull request
Jun 15, 2020
* master: M5Stack's product offering includes various ESP32-based camera devices. (espressif#4030) Fix for issue 3974 m_connectedCount incorrectly decremented when no connection exists Add a new board of KITS for IoT education (espressif#3703) update M5Camera pins (espressif#4021) Update SD_MMC.cpp (espressif#4020) Added missing wifi_provisioning dependency. (espressif#4003) HardwareSerial bugfix & improvement (espressif#3713) Allow using custom linker scripts (espressif#3735) Add M5Stack-ATOM Board (espressif#3883) Minor modifications in provisioning (espressif#3919) Add support of unified provisioning to Arduino Update install-platformio-esp32.sh add new board Handbit (espressif#3807) Move _STREAM_BOUNDARY before _STREAM_PART (espressif#3720) Add Senses's WEIZEN board from Senses IoT platform (espressif#3687) Revert "std::shared_ptr Memory Leak (espressif#3680)" (espressif#3682) std::shared_ptr Memory Leak (espressif#3680) Minimize HardwareSerial Receive and Transmit delays (espressif#3664) fix removeApbChangeCallback() error in spiStopBus() (espressif#3675) # Conflicts: # CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in README.md